Update AML to enable private IP compute #3052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marrobi
force-pushed
the
marrobi/issue2780
branch
from
173e4ff to
d57cfc6
Compare
marrobi
force-pushed
the
marrobi/issue2780
branch
from
d080d4d to
847231f
Compare
|
@damoodamoo are you or one of your team still intending to take this forward? It is now usable, however a couple of outstanding issues as detailed above. @tamirkamara if you can give this a first pass (still draft) would eb appreciated. |
tamirkamara
reviewed
Jan 18, 2023
…ch 'main' of github.com:microsoft/AzureTRE into marrobi/issue2780
|
/test-extended |
|
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/4005077826 (with refid (in response to this comment from @marrobi) |
tamirkamara
approved these changes
Jan 25, 2023
|
/test-force-approve Passed: https://github.com/microsoft/AzureTRE/actions/runs/4005077826 |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit d8ae302) (in response to this comment from @marrobi) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2780, #2971, #1846
What is being addressed
Update AML workspace to cover Private IP compute scenario
How is this addressed
Follow on work
connection_uri#3123